Fix tests. - #387
Draft
chimosky wants to merge 1 commit into
Draft
Conversation
The test_handle_updated_sources_does_not_force_gc doc strings says gc.collect() is deliberately not called after swap and the test is supposed to ensure there's no garbage collection, but it calls _handle_updated_sources which calls _freeze_resident_graph() after the swap, and that also calls gc.collect(), which nullifies the test. In test_handle_updated_sources_nulls_parents_on_old_graph, sources is a list and the test fails when hash gets called on it because list doesn't have a hash method, I created a sources mock and then set its iter to sources, and this fixes the issue as the mock can create the hash method as it needs. Signed-off-by: Chihurumnaya Ibiam <ibiamchihurumnaya@gmail.com>
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The test_handle_updated_sources_does_not_force_gc doc strings says gc.collect() is deliberately not called after swap and the test is supposed to ensure there's no garbage collection, but it calls _handle_updated_sources which calls
_freeze_resident_graph() after the swap, and that also calls gc.collect(), which nullifies the test.
In test_handle_updated_sources_nulls_parents_on_old_graph, sources is a list and the test fails when hash gets called on it because list doesn't have a hash method, I created a sources mock and then set its iter to sources, and this fixes the issue as the mock can create the hash method as it needs.
@cmttt this is for my understanding, was the behaviour in
test_handle_updated_sources_does_not_force_gcintended?Checklist
uv run ruff check .passes (no unused imports or other lint errors)uv tool run fawltydeps --check-unused --pyenv .venvpasses (no unused dependencies)CHANGELOG.mdwith my changes, if applicable